refactor(metrics): reduce per-hook boilerplate with declarative macros#806
Open
Molter73 wants to merge 1 commit into
Open
refactor(metrics): reduce per-hook boilerplate with declarative macros#806Molter73 wants to merge 1 commit into
Molter73 wants to merge 1 commit into
Conversation
Use macro_rules! to generate repetitive per-hook code from a single list of hook names, reducing the number of places that must be updated when adding a new LSM hook. - fact-ebpf/src/lib.rs: impl_metrics_t! macro generates metrics_t::accumulate() from the hook list. - fact/src/metrics/kernel_metrics.rs: define_kernel_metrics! macro generates the KernelMetrics struct, constructor, registration, and collect() method. Also refactors refresh_labels to iterate over (label, value) tuples instead of 5 separate blocks. - fact/src/metrics/mod.rs: Extract inc_label/inc_label_by helpers in EventCounter to deduplicate the label lookup pattern. Widen visibility of counter field and MetricEvents to pub(crate). - fact-ebpf/src/bpf/types.h: Reorder metrics_t fields to group all path_* hooks together. Assisted-by: claude-opus-4-6@default <noreply@opencode.ai>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
+ Coverage 27.96% 28.72% +0.76%
==========================================
Files 21 21
Lines 2596 2527 -69
Branches 2596 2527 -69
==========================================
Hits 726 726
+ Misses 1867 1798 -69
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@fact-ebpf/src/lib.rs`:
- Around line 149-158: The impl_metrics_t! macro invocation has two fields in
the wrong order compared to the C metrics_t struct definition in
fact-ebpf/src/bpf/types.h. The fields d_instantiate and path_rmdir are currently
swapped at the end of the macro argument list. Reorder the fields in the
impl_metrics_t! macro invocation to match the C struct field order exactly:
file_open, path_unlink, path_chmod, path_chown, path_rename, path_mkdir,
d_instantiate, path_rmdir. This ensures correct metric accumulation between Rust
and C code.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Enterprise
Run ID: 8421f968-219e-4e3c-a235-06d0f88ba51a
📒 Files selected for processing (3)
fact-ebpf/src/lib.rsfact/src/metrics/kernel_metrics.rsfact/src/metrics/mod.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use macro_rules! to generate repetitive per-hook code from a single list of hook names, reducing the number of places that must be updated when adding a new LSM hook.
Assisted-by: claude-opus-4-6@default noreply@opencode.ai
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Run locally and checked metrics were increasing.
Summary by CodeRabbit